Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitmproxy: 4.0.4 -> 5.0.1 #78052

Closed
wants to merge 2 commits into from
Closed

mitmproxy: 4.0.4 -> 5.0.1 #78052

wants to merge 2 commits into from

Conversation

arcz
Copy link
Member

@arcz arcz commented Jan 19, 2020 •
edited

Motivation for this change

New mitmproxy release https://mitmproxy.org/posts/releases/mitmproxy5/.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kamilchm and fpletz January 19, 2020 22:25
kamilchm
kamilchm suggested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@kamilchm kamilchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't build it without additional deps in check phase e9e0db1

@ofborg ofborg bot requested a review from kamilchm January 20, 2020 22:16
@arcz
Copy link
Member Author

arcz commented Jan 20, 2020

@kamilchm Thanks, I've updated the code. Not sure why my macOS build passed without those dependencies...

@arcz
Copy link
Member Author

arcz commented Mar 11, 2020

is there still anything to be done by me here?

@alyssais
Copy link
Member

Why are you adding the Python dependencies here instead of in python3Packages?

@arcz
Copy link
Member Author

arcz commented Mar 19, 2020

@alyssais no particular reason, I can move them python3Packages if it's better to have them there

@alyssais
Copy link
Member

alyssais commented Apr 1, 2020 via email

@ofborg ofborg bot requested a review from kamilchm April 17, 2020 10:09
@arcz
Copy link
Member Author

arcz commented Apr 19, 2020

Looks like it's been already updated in #85458

@arcz arcz closed this Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arcz @alyssais @kamilchm @Janik-Haag