nixos/snapper: automatically create the .snapshots subvolume with correct permissions #78046
Conversation
|
Looks reasonable, I haven't tested extensively because I don't use snapper on my system, but I run btrfs, so I'm happy to if no maintainers can. |
|
friendly bump @ck3d |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
| systemd.services.snapper-subvolume-setup = { | ||
| description = "Creates .snapshots subvolumes for Snapper Snapshots"; | ||
| inherit documentation; | ||
| script = let | ||
| config = cfg: "v /.snapshots 0770 root root\n" + ( | ||
| let | ||
| acl = lib.concatMapStringsSep "," (x: "${x}:r-x") ((map (u: "u:${u}") cfg.allowUsers) ++ (map (g: "g:${g}") cfg.allowGroups)); | ||
| in | ||
| optionalString (acl != "") "a /.snapshots - - - - ${acl}" | ||
| ); | ||
| cmd = cfg: "systemd-tmpfiles --create --root ${cfg.subvolume} ${builtins.toFile "snapper-subvolume-setup.conf" (config cfg)}"; | ||
| in | ||
| lib.concatStringsSep "\n" (lib.mapAttrsToList (name: cfg: cmd cfg) cfg.configs); | ||
| wantedBy = [ "multi-user.target" ]; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Why not use systemd.tmpfiles.rules for this?
There was a problem hiding this comment.
because v creates a directory instead of a submodule if / is not btrfs. So it is required to the --root argument to systemd-tmpfiles.
The alternative is to hack an idempotent wrapper around btrfs submodule create.
stale
bot
removed
the
2.status: stale
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/snapper-should-snapshots-subvolumes-be-created-automatically/22329/5 |
It looks like this PR can fix this bug? |
|
It's possible however I don't use snapper anymore so feel free to reopen this pull request for yourself and to fix the merge conflicts. |
|
@Freed-Wu found this issue trying to debug that error. In my case it was due to having a swapfile on the same subvolume: Fixed with instructions here: https://askubuntu.com/a/1206161 Afterwards snapper can make snapshots again. |
Motivation for this change
The configuration is declarative but still requires manual intervention to create
.snapshots.Only the second commit is interesting, the first one only runs nixpkgs-fmt.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)