Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs-cluster: 0.11.0 -> 0.12.1 #78138

Merged
merged 1 commit into from Mar 14, 2020
Merged

ipfs-cluster: 0.11.0 -> 0.12.1 #78138

merged 1 commit into from Mar 14, 2020

Conversation

lordcirth
Copy link
Contributor

Motivation for this change

0.12.1 is the latest version, and 0.12.0+ has ipfs-cluster-follow, which I want.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Old closure: 93.9M
New closure: 131.9M
This appears to be largely an increase in ipfs-cluster itself.

@ofborg ofborg bot requested review from jglukasik and kalbasit January 20, 2020 22:28
@alyssais alyssais merged commit 50c997c into NixOS:master Mar 14, 2020
@lordcirth lordcirth deleted the ipfs-cluster-012 branch March 14, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglukasik jglukasik Awaiting requested review from jglukasik

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lordcirth @alyssais