Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingen: unstable-2017-07-22 unstable-2019-12-09 #78102

Merged
merged 1 commit into from Jan 20, 2020
Merged

ingen: unstable-2017-07-22 unstable-2019-12-09 #78102

merged 1 commit into from Jan 20, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jan 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Probably needs most of:
#78101
#78100
#78095
#78094
#78093
#65152
#65153

This was referenced Jan 20, 2020
Merged
Merged
@ofborg ofborg bot requested a review from cillianderoiste January 20, 2020 13:15
teto
teto reviewed Jan 20, 2020
View reviewed changes
pkgs/applications/audio/ingen/default.nix
rev = "2017-07-22";
pname = "ingen";
version = "unstable-2019-12-09";
name = "${pname}-${version}";

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cant use fetchFromGitLab because of deepClone ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

@teto teto merged commit a6ecbc4 into NixOS:master Jan 20, 2020
@magnetophon magnetophon deleted the ingen branch January 20, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @teto