cinnamon.cinnamon-desktop: init at 4.4.0 #78060
Conversation
mkg20001
force-pushed
the
pkg/cinnamon-desktop
branch
2 times, most recently
from
a6ebd59
to
8a0af9e
Compare
mkg20001
force-pushed
the
pkg/cinnamon-desktop
branch
from
8a0af9e
to
76cb7bc
Compare
There was a problem hiding this comment.
There's optional alsa support https://github.com/linuxmint/cinnamon-desktop/blob/8fa6c1e329ab5b57f4df566d332fe112b58f5bff/meson_options.txt#L5, not sure if we want that.
There's some libraries in Requries and I not sure if they're relevant for the girs
cvc.pc
Requires: gio-2.0, libpulse, libpulse-mainloop-glib, gobject-2.0
cinnamon-desktop.pc
Requires: gtk+-3.0
That's glib gtk3 and pulseaudio.
| postPatch = '' | ||
| chmod +x install-scripts/meson_install_schemas.py # patchShebangs requires executable file | ||
| patchShebangs install-scripts/meson_install_schemas.py | ||
| sed "s|/usr/share|/run/current-system/sw/share|g" -i ./schemas/* |
There was a problem hiding this comment.
We should try to hardcode these paths into the schemas from which package they come from.
I'm seeing
- https://github.com/linuxmint/cinnamon-desktop/blob/b823080f53b3b32afb0e0956ba2a23e2644c06e3/schemas/org.cinnamon.desktop.a11y.keyboard.gschema.xml.in.in#L114
- https://github.com/linuxmint/cinnamon-desktop/blob/b823080f53b3b32afb0e0956ba2a23e2644c06e3/schemas/org.cinnamon.desktop.wm.preferences.gschema.xml.in.in#L302
I'm not sure what package these sounds come from, so I guess you can leave them unpatched and fix them when you add the package. (guessing cinnamon-sounds?)
There was a problem hiding this comment.
It's from cinnamon-common which is the root package
Circular dependency if we patch this properly?
maciej@mkg-lenovo:~/Projekte/nixpkgs$ readlink -f /usr/share/cinnamon/sounds/
/nix/store/k6plfqprqx4600cz7v623knflqkzqzdi-cinnamon-common-4.4.1/share/cinnamon/sounds
(also don't ask me about the dark magic that made /usr/share a thing xD)
There was a problem hiding this comment.
It's from cinnamon-common which is the root package
Do you mean it's at the top of the dependency tree?
If so then it shouldn't be an issue, but if ciinnamon-common depends on cinnamon-desktop it will be circular, and we'd have to ask cinnamon to ship those files somewhere else.
mkg20001
force-pushed
the
pkg/cinnamon-desktop
branch
2 times, most recently
from
ce1b5a7
to
13489be
Compare
mkg20001
force-pushed
the
pkg/cinnamon-desktop
branch
from
13489be
to
e105a95
Compare
Motivation for this change
Needed for nemo #77979
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)