Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normal screenshot mode may incorrectly show a huge screenshot warning dialog #7950

Closed
JGRennison opened this issue Jan 20, 2020 · 3 comments · Fixed by #7959
Closed

Normal screenshot mode may incorrectly show a huge screenshot warning dialog #7950

JGRennison opened this issue Jan 20, 2020 · 3 comments · Fixed by #7959

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

Since e558aa8 / 6dfe5c8

Expected result

Clicking "Normal Screenshot" does not show a "Huge screenshot" dialog, at any zoom level.

Actual result

Clicking "Normal Screenshot" may show a "Huge screenshot" dialog at higher zoom levels, where the reported dimensions are the same as in the "Default zoom screenshot" case.
The actual size of the output screenshot does not match the large values reported in the "Huge screenshot" dialog, nor is the screenshot rendered at that resolution at any point.

Steps to reproduce

Zoom fully out.
Select "Normal screenshot" from the screenshot window.
Observe the "Huge Screenshot" dialog.
Select "Yes".
Observe the output screenshot file.
@JMcKiern
Copy link
Contributor

I'll have a look at it on the weekend if no one else gets around to it

JMcKiern added a commit to JMcKiern/OpenTTD that referenced this issue Jan 25, 2020
@JMcKiern
Fix OpenTTD#7950: Incorrect setup of normal screenshot viewport
e06858f
JMcKiern added a commit to JMcKiern/OpenTTD that referenced this issue Jan 25, 2020
@JMcKiern
Fix OpenTTD#7950: Incorrect setup of normal screenshot viewport
3fff281
@JMcKiern JMcKiern mentioned this issue Jan 25, 2020
Merged
LordAro pushed a commit that referenced this issue Jan 26, 2020
@JMcKiern @LordAro
Fix #7950: Incorrect setup of normal screenshot viewport
2158e26
@James103
Copy link
Contributor

Could a very large monitor / display (as in a resolution of 12K, 11520 x 6480, or 6480p) still cause the huge screenshot dialog to pop up when taking a regular screenshot in full-screen? If that is the case, then the huge screenshot threshold will have to be eventually raised (currently at 8192p square = 67 million pixels) once 12K and 16K become the norm for high-end displays and monitors (i.e. several decades from now).

@JMcKiern
Copy link
Contributor

JMcKiern commented Jan 31, 2020 •
edited

It could, yeah. I guess it depends what the purpose of the dialog is. It might be just to warn the user that "this file will be a big one, don't be surprised if it takes a little time" rather than "this screenshot will be bigger than your monitor".

Either way, it's grand for now

douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@JMcKiern @douiwby
Fix OpenTTD#7950: Incorrect setup of normal screenshot viewport
693f0c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7950: Incorrect setup of Normal Screenshot ViewPort JMcKiern/OpenTTD
3 participants
@JGRennison @JMcKiern @James103