Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: 4.0.3 -> 4.1.0 #78056

Merged
merged 2 commits into from Jan 28, 2020
Merged

platformio: 4.0.3 -> 4.1.0 #78056

merged 2 commits into from Jan 28, 2020

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Jan 19, 2020

Things done
  • Tested with esphome: Built some images and deployed to some ESPs.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz fpletz requested a review from makefu January 19, 2020 23:01
makefu
makefu approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested platformio with esphome, compilation and serial-console upload works.

Kudos for patching out the weird runtime spdx list fetching.

@makefu
Copy link
Contributor

makefu commented Jan 20, 2020

@fpletz Out of interest, is local ota-upload working for you?

$ avahi-resolve -n frosch.local
frosch.local	192.168.0.119

$ esphome frosch.yaml upload
INFO Reading configuration frosch.yaml...
Found multiple options, please choose one:
  [1] /dev/ttyUSB0 (USB2.0-Serial)
  [2] Over The Air (frosch.local)
(number): 2
INFO Resolving IP address of frosch.local
WARNING Exception occurred:
Traceback (most recent call last):
  File "/nix/store/lv8x1rbfk72686y7701pq8iwvflvp8bb-esphome-1.14.3/lib/python3.7/site-packages/esphome/zeroconf.py", line 757, in send
    bytes_sent = s.sendto(packet, 0, (_MDNS_ADDR, _MDNS_PORT))
OSError: [Errno 126] Required key not available

cheers

@fpletz
Copy link
Member Author

fpletz commented Jan 20, 2020

@makefu I have done OTA but only with a custom domain and proper DNS resolution in place (so no MDNS). I can try and possibly fix this in the evening.

However, according to sendto(3), this function shouldn't return ENOKEY. I have found some references to Wireguard, though. Possibly esphome is trying to send multicast packets via a local Wireguard interface but there is no peer with the multicast address as allowed IP.

@makefu
Copy link
Contributor

makefu commented Jan 20, 2020

@fpletz Thanks for debugging, i will try to disable the wireguard interface

@makefu
Copy link
Contributor

makefu commented Jan 20, 2020 •
edited

After shutting down the wireguard interface:

INFO Resolving IP address of frosch.local
WARNING Exception occurred:
Traceback (most recent call last):
  File "/nix/store/lv8x1rbfk72686y7701pq8iwvflvp8bb-esphome-1.14.3/lib/python3.7/site-packages/esphome/zeroconf.py", line 757, in send
    bytes_sent = s.sendto(packet, 0, (_MDNS_ADDR, _MDNS_PORT))
OSError: [Errno 101] Network is unreachable
INFO  -> 192.168.0.119
INFO Uploading frosch/.pioenvs/frosch/firmware.bin (410656 bytes)
Uploading: [============================================================] 100% Done...

INFO Waiting for result...
INFO OTA successful
INFO Successfully uploaded program.

Awesome!

@makefu makefu mentioned this pull request Jan 20, 2020
Closed
10 tasks
@makefu
Copy link
Contributor

makefu commented Jan 21, 2020

Once this PR hit master, can we backport to stable? I'd love my working esphome!

jonringer
jonringer reviewed Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please drop the:

pythonPackages.marshmallow2: init at 2.20.5

commit

@fpletz fpletz merged commit f7b45fd into NixOS:master Jan 28, 2020
@fpletz fpletz deleted the pkg/platformio-4.1.0 branch January 28, 2020 15:14
@makefu
Copy link
Contributor

makefu commented Jan 28, 2020

please please backport to stable 👍

@Mic92
Copy link
Member

Mic92 commented Jan 28, 2020

This requires some adaption before it can be backported to stable.

anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@fpletz @anna328p
Merge pull request NixOS#78056 from mayflower/pkg/platformio-4.1.0
667e60c 
platformio: 4.0.3 -> 4.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@jonringer jonringer jonringer left review comments

@makefu makefu makefu approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fpletz @makefu @Mic92 @jonringer