Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pam_gnupg: init at 0.1 #78143

Merged
merged 1 commit into from Sep 13, 2020
Merged

pam_gnupg: init at 0.1 #78143

merged 1 commit into from Sep 13, 2020

Conversation

mtreca
Copy link
Contributor

@mtreca mtreca commented Jan 21, 2020

Motivation for this change

Add the pam_gnupg module that unlocks gnupg keys on login.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/os-specific/linux/pam_gnupg/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/pam_gnupg/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/pam_gnupg/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/pam_gnupg/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/pam_gnupg/default.nix Outdated Show resolved Hide resolved
pname = "pam_gnupg";
version = "0.1";

src = fetchurl {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchFromGitHub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

homepage = https://github.com/cruegge/pam-gnupg;
description = "Unlock GnuPG keys on login";
license = licenses.gpl3;
maintainers = with maintainers; [ 0x6d6178 ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and it seems there's a problem with your username :)

Suggested change
maintainers = with maintainers; [ 0x6d6178 ];
maintainers = with maintainers; [ vxid ];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I am about to change Github accounts so I put my new identity there.

@doronbehar
Copy link
Contributor

Thanks for your contribution @Vxid, one more thing I noticed now: Please change the name of the PR to reflect the commit message + usually most of the times it's init not Init (lowercase).

1 similar comment
@doronbehar

This comment has been minimized.

@mtreca mtreca changed the title pam_gnupg: Init at 1.0 pam_gnupg: init at 0.1 Feb 27, 2020
@mtreca
Copy link
Contributor Author

mtreca commented Feb 27, 2020

@doronbehar All done, thanks a lot for your help and feedback.

@stale
Copy link

stale bot commented Aug 25, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 25, 2020
@mtreca
Copy link
Contributor Author

mtreca commented Aug 25, 2020

Hm, I still think it would be good to merge this PR. @doronbehar any idea who could be able to merge this? Thanks in advance!

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 25, 2020
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/pam_gnupg/default.nix Outdated Show resolved Hide resolved
@NickHu NickHu mentioned this pull request Sep 10, 2020
10 tasks
@NickHu
Copy link
Contributor

NickHu commented Sep 10, 2020

@mtreca Thanks for your contribution! I rebased onto master for you and made the minor changes suggested by @zowoq. I would have merged too, but I can't find a GitHub account under the username 0x6d6178 - you mentioned something about switching accounts, so I'll leave it to you to update the maintainer information and then I can merge.

Add the pam_gnupg module that unlocks gnupg keys on login.
@mtreca
Copy link
Contributor Author

mtreca commented Sep 13, 2020

@zowoq Sorry for the long delay, and thanks for the code review.
@NickHu Thanks a lot for implementing these changes. I did change (again) my github username, and updated the files accordingly.

@NickHu NickHu merged commit 5d92cf5 into NixOS:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants