Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.16.4 -> 1.16.5 #78098

Merged
merged 1 commit into from Jan 22, 2020
Merged

kubernetes: 1.16.4 -> 1.16.5 #78098

merged 1 commit into from Jan 22, 2020

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Jan 20, 2020 •
edited by jonringer

Kubernetes changelog: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.16.md#changelog-since-v1164

Motivation for this change

Primarily this:

Fixed a regression where the kubelet would fail to update the ready status of pods.

Other relevant info from the changelog:

Kubernetes 1.16.5+ now requires go1.13.4+ to build

DNS and RBAC tests run clean locally.
A separate PR for release-19.09 will arrive shortly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@johanot johanot mentioned this pull request Jan 20, 2020
Merged
10 tasks
saschagrunert
saschagrunert approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonringer
jonringer approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
patch bump

[6 built, 4 copied (389.4 MiB), 98.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78098
3 package built:
kubectl kubectx kubernetes

@jonringer jonringer merged commit a96ed5d into NixOS:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johanot @saschagrunert @jonringer