Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipxe: ebf2eaf515e46abd43bc798e7e4ba77bfe529218 --> 1.20.1 #78150

Merged
merged 1 commit into from Jan 22, 2020
Merged

ipxe: ebf2eaf515e46abd43bc798e7e4ba77bfe529218 --> 1.20.1 #78150

merged 1 commit into from Jan 22, 2020

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Jan 21, 2020 •
edited

Motivation for this change

ipxe: ebf2eaf515e46abd43bc798e7e4ba77bfe529218 --> 1.20.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    @CMCDragonkai

@Rakesh4G Rakesh4G requested a review from volth January 21, 2020 10:09
@ofborg ofborg bot requested a review from ehmry January 21, 2020 10:15
@Mic92
Copy link
Member

Mic92 commented Jan 21, 2020

cc @cleverca22

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jan 22, 2020 •
edited

Since we are no longer using a specific revision, but a release tag, then it's not necessary to name it like this. It should be done to just use pname = "ipxe"; and "version = "1.20.1";".

And then we can use fetchFromGithub like this:

    src = fetchFromGitHub {
      owner = "ipxe";
      repo = "ipxe";
      rev = "v1.20.1";
      sha256 = "0w7h7y97gj9nqvbmsg1zp6zj5mpbbpckqbbx7bpp6k3ahy5fk8zp";
    };

@Rakesh4G
Copy link
Contributor Author

OK, @CMCDragonkai . I will update accordingly.

Mic92
Mic92 reviewed Jan 22, 2020
View reviewed changes
pkgs/tools/misc/ipxe/default.nix Outdated
src = fetchFromGitHub {
owner = "ipxe";
repo = "ipxe";
rev = "v1.20.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v1.20.1";
rev = "v${version}";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Mic92
Mic92 reviewed Jan 22, 2020
View reviewed changes
pkgs/tools/misc/ipxe/default.nix Outdated
@@ -20,14 +18,16 @@ let
in

stdenv.mkDerivation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs rec so that version can be used in fetchFromGitHub

Suggested change
stdenv.mkDerivation {
stdenv.mkDerivation rec {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Rakesh4G
Copy link
Contributor Author

Hi @Mic92 ,

I have added the suggested changes.

Thanks.

@ehmry
Copy link
Contributor

ehmry commented Jan 22, 2020

@GrahamcOfBorg build ipxe

ehmry
ehmry approved these changes Jan 22, 2020
View reviewed changes
pkgs/tools/misc/ipxe/default.nix Outdated Show resolved Hide resolved
@ehmry ehmry merged commit f82528a into NixOS:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rakesh4G @Mic92 @CMCDragonkai @ehmry