Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyparsing: improve tests #78145

Merged
merged 1 commit into from Jan 21, 2020
Merged

pythonPackages.pyparsing: improve tests #78145

merged 1 commit into from Jan 21, 2020

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Jan 21, 2020 •
edited

  • Fetch pyparsing from GitHub instead of PyPi
  • Add tests
Motivation for this change

A back-bone of many packages like pyparsing needs to be tested

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kamadorueda
pythonPackages.pyparsing: improve tests
2f046e8 
- Fetch pyparsing from GitHub instead of PyPi
- Add tests
@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.pyparsing
@GrahamcOfBorg build python3Packages.pyparsing
@GrahamcOfBorg build python38Packages.pyparsing

@jonringer
Copy link
Contributor

darwin is timing-out due to llvm build, going to merge

@jonringer jonringer merged commit cdfb32d into NixOS:staging Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamadorueda @jonringer