Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matomo: 3.13.0 -> 3.13.1 #78128

Merged
merged 1 commit into from Jan 21, 2020
Merged

matomo: 3.13.0 -> 3.13.1 #78128

merged 1 commit into from Jan 21, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 20, 2020

Motivation for this change

Upstream release: https://matomo.org/changelog/matomo-3-13-1/

"This release is also rated critical and includes a major security fix."

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from florianjacob and Kiwi January 20, 2020 20:04
@marsam marsam merged commit 644e74f into NixOS:master Jan 21, 2020
@marsam
Copy link
Contributor

marsam commented Jan 21, 2020

Thanks!
backported to 19.09 in 4efac13

@ajs124 ajs124 deleted the upd/matomo branch January 21, 2020 01:04
@florianjacob
Copy link
Contributor

florianjacob commented Jan 21, 2020 •
edited

Thanks to all for the quick update! :)
For next time, note that there is an applicable NixOS test, i.e. @GrahamcOfBorg test matomo matomo-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwi Kiwi Kiwi approved these changes

@florianjacob florianjacob Awaiting requested review from florianjacob

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @marsam @florianjacob @Kiwi