Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsduck: init at 3.19-1520 #78131

Closed
wants to merge 2 commits into from
Closed

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

Wanted to test video stream
@dasJ

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus Lassulus changed the title Tsduck tsduck: init at 3.19-1520 Jan 24, 2020
@Lassulus
Copy link
Member

hash mismatch in fixed-output derivation '/nix/store/hr4723z3p1n0rkcqxwvkc9rvfl7g79ji-source':
  wanted: sha256:1k80dy16b5093qd6lx977b5v8jgdmb0h25jvlgi2gpl6l77c0s0b
  got:    sha256:1w7qq4hjk144dwqhfrkbf7qgz1i8pf8z8phyk9gwc4yd9i5rx8an
cannot build derivation '/nix/store/cvhq2js30vaksfrh5y2x56rf17ml3w4y-tsduck-3.19-1520.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yp6xlwz3igma8dyzmbb2kcvsw0b3ad8r-env.drv': 1 dependencies couldn't be built

description = "An extensible toolkit for MPEG/DVB transport streams";
homepage = "https://tsduck.io/";
license = with licenses; [ bsd2 ];
maintainers = with maintainers; [ das_j ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to add yourself here and in the other package?

@Lassulus
Copy link
Member

Lassulus commented Feb 8, 2020

builder for '/nix/store/1p2fja8d3i583sfkn68gznmlhmvsi9si-tsduck-3.19-1520.drv' failed with exit code 2; last 10 log lines:
  configuring
  no configure script, doing nothing
  building
  build flags: SHELL=/nix/store/715fljdrspphbdk255r729zxp4w7lcgk-bash-4.4-p23/bin/bash NOPCSC=1 LDFLAGS_EXTRA=/nix/store/wwaln2rihi440sybf79ij0lif73sm8ic-dtapi-2019.11.0/Lib/GCC5.1_CXX11_ABI1/DTAPI64.o
  ./dtapi-config.sh --url >LinuxSDK.version
  curl: (6) Could not resolve host: www.dektec.com
  curl: (6) Could not resolve host: www.dektec.com
  dtapi-config.sh: cannot locate LinuxSDK location from Dektec
  make[1]: *** [Makefile:71: geturl] Error 1
  make: *** [Makefile:58: default] Error 2
cannot build derivation '/nix/store/i3g93hp5y6j5dsyxr5h646y6msiilibb-env.drv': 1 dependencies couldn't be built

@stale
Copy link

stale bot commented Aug 6, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 6, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 8, 2020
@ofborg ofborg bot requested a review from dasJ October 8, 2020 11:36
@Scriptkiddi
Copy link
Contributor Author

@Lassulus

Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refrain from adding me as maintainer of random packages.

@Scriptkiddi
Copy link
Contributor Author

Please refrain from adding me as maintainer of random packages.

done

@Lassulus
Copy link
Member

builder for '/nix/store/5cb1xhnz1w5jji5jbw3jaw7asnlk7r3f-tsduck-3.19-1520.drv' failed with exit code 2; last 10 log lines:
  configuring
  no configure script, doing nothing
  building
  build flags: SHELL=/nix/store/2jysm3dfsgby5sw5jgj43qjrb5v79ms9-bash-4.4-p23/bin/bash NOPCSC=1 LDFLAGS_EXTRA=/nix/store/h9ws6npv22znvnw73xyxfya0mh0jkqsa-dtapi-2020.08.0/Lib/GCC5.1_CXX11_ABI1/DTAPI64.o
  ./dtapi-config.sh --url >LinuxSDK.version
  curl: (6) Could not resolve host: www.dektec.com
  curl: (6) Could not resolve host: www.dektec.com
  dtapi-config.sh: cannot locate LinuxSDK location from Dektec
  make[1]: *** [Makefile:71: geturl] Error 1
  make: *** [Makefile:58: default] Error 2
cannot build derivation '/nix/store/yqqqvm54pp7lhvgp1fqib799ycx2pg6c-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 0.0 MiB DL]

@dasJ
Copy link
Member

dasJ commented Oct 15, 2020

Also, 3.23-1965 is out now

Comment on lines +19 to +20
cd DTAPI
cp -r Include/ Lib/ $out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd DTAPI
cp -r Include/ Lib/ $out
cp -r DTAPI/Include/ DTAPI/Lib/ $out

Comment on lines +19 to +20
mkdir -p dektec/LinuxSDK/DTAPI
cp -r ${dtapi}/* dektec/LinuxSDK/DTAPI/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use symlink to reduce the final size.

Comment on lines +26 to +27
buildInputs = [ curl linuxHeaders ];
nativeBuildInputs = [ curl makeWrapper ]; # Makefile calls curl-config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [ curl linuxHeaders ];
nativeBuildInputs = [ curl makeWrapper ]; # Makefile calls curl-config
# Makefile calls curl-config
nativeBuildInputs = [ curl makeWrapper ];
buildInputs = [ curl linuxHeaders ];

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builder for '/nix/store/xpyzhkmc09zrghm6zl12w8hp8mdppcmm-tsduck-3.19-1520.drv' failed with exit code 2; last 10 log lines:
  configuring
  no configure script, doing nothing
  building
  build flags: SHELL=/nix/store/516z50fm1jbpcl32qnzy7kynrh0vl22w-bash-4.4-p23/bin/bash NOPCSC=1 LDFLAGS_EXTRA=/nix/store/jdlxw7fpifh0zwp2ad98cy95fs7gxgm0-dtapi-2020.08.0/Lib/GCC5.1_CXX11_ABI1/DTAPI64.o
  ./dtapi-config.sh --url >LinuxSDK.version
  curl: (6) Could not resolve host: www.dektec.com
  curl: (6) Could not resolve host: www.dektec.com
  dtapi-config.sh: cannot locate LinuxSDK location from Dektec
  make[1]: *** [Makefile:71: geturl] Error 1
  make: *** [Makefile:58: default] Error 2
cannot build derivation '/nix/store/vh5sv9pd1wc8qywmagdy43515s9zkazx-env.drv': 1 dependencies couldn't be built

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 13, 2022
@Artturin Artturin closed this Apr 13, 2022
@Lassulus
Copy link
Member

this PR is comedy

@Scriptkiddi Scriptkiddi deleted the tsduck branch April 15, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants