Skip to content

teleprompter: init at 2.3.4 #78130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

teleprompter: init at 2.3.4 #78130

merged 1 commit into from
Jan 24, 2020
+44 −0

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

ajs124
ajs124 requested changes Jan 20, 2020
View reviewed changes
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 20, 2020
@Scriptkiddi Scriptkiddi force-pushed the telepromter branch 2 times, most recently from 94af66c to 8ae2207 Compare January 20, 2020 20:57
@mmahut mmahut changed the title Telepromter telepromter: init at 2.3.4 Jan 21, 2020
@mmahut
Copy link
Member

mmahut commented Jan 21, 2020 

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   355    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download imaginary-telepromter-2.3.4-64bit.tar.gz from any mirror```

@Scriptkiddi Scriptkiddi force-pushed the telepromter branch 2 times, most recently from 86156a2 to 29027d9 Compare January 21, 2020 12:05
@Scriptkiddi Scriptkiddi changed the title telepromter: init at 2.3.4 teleprompter: init at 2.3.4 Jan 21, 2020
@Scriptkiddi
Copy link
Contributor Author

@mmahut fixed

Lassulus
Lassulus approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit 05626cc into NixOS:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut

@ajs124 ajs124

@Lassulus Lassulus

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Scriptkiddi @mmahut @Lassulus @ajs124