Skip to content

Update wine{unstable,staging,gecko,mono,winetricks} #78081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I noticed it was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@lovesegfault
Copy link
Member Author

(Still building locally)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 20, 2020
@lovesegfault
Copy link
Member Author

@GrahamcOfBorg build wine

@lovesegfault
Copy link
Member Author

@GrahamcOfBorg build wineFull

Verified

This commit was signed with the committer’s verified signature.
lovesegfault Bernardo Meurer

Verified

This commit was signed with the committer’s verified signature.
lovesegfault Bernardo Meurer

Verified

This commit was signed with the committer’s verified signature.
lovesegfault Bernardo Meurer

Verified

This commit was signed with the committer’s verified signature.
lovesegfault Bernardo Meurer
@lovesegfault lovesegfault force-pushed the wine-bump branch 2 times, most recently from a1847bb to b202023 Compare January 20, 2020 09:27
@lovesegfault lovesegfault requested review from avnik, bendlas and tadeokondrak and removed request for avnik January 20, 2020 09:34
@lovesegfault lovesegfault force-pushed the wine-bump branch 2 times, most recently from 6a42eff to b5530f5 Compare January 20, 2020 10:35
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update of wine itself (outside unrelated commit) is ok
Could you remove extra commit, please?

Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit ce674e5 into NixOS:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants