Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluidasserts: 20.1.22554 -> 20.1.28253 #78111

Merged
merged 1 commit into from Jan 21, 2020
Merged

fluidasserts: 20.1.22554 -> 20.1.28253 #78111

merged 1 commit into from Jan 21, 2020

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Jan 20, 2020 •
edited

  • bumps the fluidasserts version to 20.1.28253
  • in this version the build process is deterministic and
    reproducible (you'll get the same hash on multiple builds)
  • refactored the tests accordingly to a maintainer suggestion in last PR
  • added many new tests :)
  • see: https://gitlab.com/fluidattacks/asserts/issues/873
Motivation for this change
  • Reproducible builds
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kamadorueda
fluidasserts: 20.1.22554 -> 20.1.28253
72c0afa 
- bumps the fluidasserts version to 20.1.28253
- in this version the build process is deterministic and
  reproducible (you'll get the same hash on multiple builds)
- see: https://gitlab.com/fluidattacks/asserts/issues/873
jonringer
jonringer approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78111
1 package built:
fluidasserts

@jonringer
Copy link
Contributor

@GrahamcOfBorg build fluidasserts

@jonringer
Copy link
Contributor

darwin builds are timing out, if it's broken, we will revisit it :)

@jonringer jonringer merged commit 2dddf14 into NixOS:master Jan 21, 2020
@kamadorueda
Copy link
Member Author

@jonringer gonna inspect it https://gitlab.com/fluidattacks/asserts/issues/875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamadorueda @jonringer