nixos/buildkite-agent: set StateDirectory=buildkite-agent, extend vm test #78140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run buildkite from inside /var/lib/buildkite-agent, and do some setup at runtime (as we need to assemble the config file containing secrets at runtime). We did rely on rely on users.users."buildkite-agent".createHome to set up that directory. However, when configuring another user to run buildkite as (by services.buildkite-agent.user), this directory doesn't exist automatically. Let's not require the user to set it up, instead just use `StateDirectory=buildkite-agent` unconditionally to create it.
|
Superseded by #78160. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run buildkite from inside /var/lib/buildkite-agent, and do some setup
at runtime (as we need to assemble the config file containing secrets at
runtime).
We did rely on rely on users.users."buildkite-agent".createHome to set
up that directory.
However, when configuring another user to run buildkite as
(by services.buildkite-agent.user), this directory doesn't exist
automatically.
Let's not require the user to set it up, instead just use
StateDirectory=buildkite-agentunconditionally to create it.Also, extend the VM test to create a second runner, running as a different user, and having no ssh key configured.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)