[css-flexbox] Migrate bug580586.html test from css3/flexbox to WPT #22493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 27, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2124262
branch
2 times, most recently
from
06875ee
to
a4ef29b
Compare
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also, rename its filename to something more descriptive and less Chromium-specific (it currently references crbug.com/580586). Bug: 1063749 Change-Id: Ia277335a3efd2f42d27d2ad7bd2a45d2fe4b6708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124262 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#754245}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2124262
branch
from
a4ef29b
to
810b663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate this test out of third_party/blink/web_tests/css3/flexbox
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.
Also, rename its filename to something more descriptive and less
Chromium-specific (it currently references crbug.com/580586).
Bug: 1063749
Change-Id: Ia277335a3efd2f42d27d2ad7bd2a45d2fe4b6708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124262
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754245}