Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelogin: init at 0.0.6 #83519

Merged
merged 1 commit into from Sep 30, 2020
Merged

kubelogin: init at 0.0.6 #83519

merged 1 commit into from Sep 30, 2020

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Mar 27, 2020

Motivation for this change

Add kubelogin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurrriq
Copy link
Member Author

yurrriq commented Mar 27, 2020

@kalbasit, is this the preferred usage of buildGoModule?

@ofborg ofborg bot requested a review from kalbasit March 27, 2020 20:01
yurrriq added a commit to yurrriq/nur-packages that referenced this pull request Apr 12, 2020
@yurrriq
kubelogin: init at 0.0.2
e8f43e0 
NixOS/nixpkgs#83519
@yurrriq
Copy link
Member Author

yurrriq commented May 14, 2020

Any traction on this? There's a 0.0.3 release now too.

@yurrriq yurrriq changed the title kubelogin: init at 0.0.2 kubelogin: init at 0.0.4 Jun 17, 2020
@yurrriq
Copy link
Member Author

yurrriq commented Jun 17, 2020

I've updated this to 0.0.4 and modSha256 -> vendorSha256

@yurrriq yurrriq changed the title kubelogin: init at 0.0.4 kubelogin: init at 0.0.6 Sep 30, 2020
@yurrriq
Copy link
Member Author

yurrriq commented Sep 30, 2020

Updated to 0.0.6 now, and heeded feedback from @doronbehar, thanks!

@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 83519 1

1 package built:
  • kubelogin

@doronbehar doronbehar merged commit 6dd3ddd into NixOS:master Sep 30, 2020
@yurrriq yurrriq deleted the add-kubelogin branch September 30, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurrriq @doronbehar