Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin: 10.5.0 -> 10.5.2 #83494

Merged
merged 1 commit into from Mar 28, 2020
Merged

jellyfin: 10.5.0 -> 10.5.2 #83494

merged 1 commit into from Mar 28, 2020

Conversation

minijackson
Copy link
Member

@minijackson minijackson commented Mar 27, 2020 •
edited

Motivation for this change

Bug fixes release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @nyanloutre

@ofborg ofborg bot requested a review from nyanloutre March 27, 2020 13:40
spacekookie
spacekookie approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@spacekookie spacekookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jonringer
Copy link
Contributor

@ofborg test jellyfin

@jonringer jonringer merged commit 3cff761 into NixOS:master Mar 28, 2020
@minijackson minijackson deleted the jellyfin-10.5.2 branch February 26, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacekookie spacekookie spacekookie approved these changes

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minijackson @jonringer @spacekookie