Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ntlm-auth: 1.0.3 -> 1.4.0 to fix build #83560

Merged
merged 1 commit into from Mar 28, 2020
Merged

pythonPackages.ntlm-auth: 1.0.3 -> 1.4.0 to fix build #83560

merged 1 commit into from Mar 28, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 28, 2020 •
edited

On master and 20.03, this is failing to build on python 3.8.

https://hydra.nixos.org/build/115517329
https://hydra.nixos.org/build/114714922

CC @NixOS/nixos-release-managers
ZHF: #80379

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020 

[9 built (1 failed), 5 copied (0.1 MiB), 0.1 MiB DL]
error: build of '/nix/store/fkxj9jzlxkm5jrhm3sqfmjc46xgzpy0w-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/83560
1 package marked as broken and skipped:
python27Packages.resampy

1 package failed to build:
fluidasserts

12 package built:
python27Packages.IBMQuantumExperience python27Packages.ntlm-auth python27Packages.pywinrm python27Packages.requests_ntlm python37Packages.IBMQuantumExperience python37Packages.ntlm-auth python37Packages.pywinrm python37Packages.qiskit-ibmq-provider python37Packages.requests_ntlm python38Packages.IBMQuantumExperience python38Packages.ntlm-auth python38Packages.requests_ntlm

fluidasserts appears to be broken on master due to unrelated protobuf issues.

@bhipple bhipple mentioned this pull request Mar 28, 2020
Merged
@ofborg ofborg bot requested a review from elasticdog March 28, 2020 02:04
@worldofpeace
Copy link
Contributor

What was changed in this update, are there changelogs? 1.0.3 -> 1.4.0 could be a big update. It might be ok if it is a leaf package, but maybe we could use a patch to fix it for 3.8.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020

The changelog looks relatively innocuous and does not appear to have any breaking changes:
https://github.com/jborean93/ntlm-auth/releases

I've built all the reverse dependencies successfully with nixpkgs-review above, and they pass their build/test -- but I don't actually use this pkg personally and haven't done any manual end-to-end integration testing.

@bhipple @nh2
pythonPackages.ntlm-auth: 1.0.3 -> 1.4.0 to fix build
97f09ff 
On master and 20.03, this is failing to build on `python 3.8`.

https://hydra.nixos.org/build/115517329
https://hydra.nixos.org/build/114714922

CC @NixOS/nixos-release-managers
ZHF: NixOS#80379

Co-Authored-By: Niklas Hambüchen <mail@nh2.me>
@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020 •
edited

Good catch on the license; updated. I also amended the PR description with links to failing Hydra jobs on trunk and release-20.03, per suggestion from @worldofpeace.

@nh2
Copy link
Contributor

nh2 commented Mar 28, 2020

In case it is useful, I also ran nix-review on the previous 20.03 version of this: #83564 (comment)

worldofpeace
worldofpeace approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@worldofpeace worldofpeace merged commit 68d45cb into NixOS:master Mar 28, 2020
@bhipple bhipple deleted the u/ntlm-auth branch June 2, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@elasticdog elasticdog Awaiting requested review from elasticdog

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @worldofpeace @nh2