Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.ntlm-auth: 1.0.3 -> 1.4.0 to fix build #83564

Merged
merged 1 commit into from Mar 29, 2020
Merged

[20.03] pythonPackages.ntlm-auth: 1.0.3 -> 1.4.0 to fix build #83564

merged 1 commit into from Mar 29, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 28, 2020 •
edited

Backports #83560

Fixed failing build:
https://hydra.nixos.org/build/115517329

CC @NixOS/nixos-release-managers
ZHF: #80379

(cherry picked from commit 8cd2c6d579624222c4a52e2034d090720d75f24e)

@ofborg ofborg bot requested a review from elasticdog March 28, 2020 02:33
@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020

We made some changes in #83560, and may make more depending on testing, so I am going to close this and re-open when we have the final commit ready for cherry-picking.

@bhipple bhipple closed this Mar 28, 2020
@nh2
Copy link
Contributor

nh2 commented Mar 28, 2020 •
edited

In case it is still useful, here's my nix-review output on 20.03:

$ nix-review pr --checkout commit 83564
...
error: build of '/nix/store/zkagvwpddw362z15yi7fak541qyxa4j2-python3.8-pywinrm-0.4.1.drv' failed: builder for '/nix/store/zkagvwpddw362z15yi7fak541qyxa4j2-python3.8-pywinrm-0.4.1.drv' failed with exit code 1
builder for '/nix/store/zkagvwpddw362z15yi7fak541qyxa4j2-python3.8-pywinrm-0.4.1.drv' failed with exit code 1; last 10 log lines:
  ModuleNotFoundError: No module named 'winkerberos'
  
  
  ----------------------------------------------------------------------
  Ran 25 tests in 0.014s
  
  FAILED (errors=2)
  Test failed: <unittest.runner.TextTestResult run=25 errors=2 failures=0>
  error: Test failed: <unittest.runner.TextTestResult run=25 errors=2 failures=0>
  builder for '/nix/store/zkagvwpddw362z15yi7fak541qyxa4j2-python3.8-pywinrm-0.4.1.drv' failed with exit code 1
error: build of '/nix/store/ygm1hpsd8yhkdbrdbckva9hgpx9lmd5n-python3.7-pywinrm-0.4.1.drv' failed: builder for '/nix/store/ygm1hpsd8yhkdbrdbckva9hgpx9lmd5n-python3.7-pywinrm-0.4.1.drv' failed with exit code 1
builder for '/nix/store/ygm1hpsd8yhkdbrdbckva9hgpx9lmd5n-python3.7-pywinrm-0.4.1.drv' failed with exit code 1; last 10 log lines:
  ModuleNotFoundError: No module named 'winkerberos'
  
  
  ----------------------------------------------------------------------
  Ran 25 tests in 0.029s
  
  FAILED (errors=2)
  Test failed: <unittest.runner.TextTestResult run=25 errors=2 failures=0>
  error: Test failed: <unittest.runner.TextTestResult run=25 errors=2 failures=0>
  builder for '/nix/store/ygm1hpsd8yhkdbrdbckva9hgpx9lmd5n-python3.7-pywinrm-0.4.1.drv' failed with exit code 1
cannot build derivation '/nix/store/afsihvvkwx4j7h6wlx9b4qfv0095azvy-env.drv': 2 dependencies couldn't be built
[11 built (2 failed), 202 copied (450.4 MiB), 28.5 MiB DL]
error: build of '/nix/store/afsihvvkwx4j7h6wlx9b4qfv0095azvy-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/83564
7 package marked as broken and skipped:
python27Packages.exchangelib python37Packages.exchangelib python37Packages.qasm2image python37Packages.qiskit python38Packages.exchangelib python38Packages.qasm2image python38Packages.qiskit

2 package failed to build:
python37Packages.pywinrm python38Packages.pywinrm

10 package built:
python27Packages.IBMQuantumExperience python27Packages.ntlm-auth python27Packages.pywinrm python27Packages.requests_ntlm python37Packages.IBMQuantumExperience python37Packages.ntlm-auth python37Packages.requests_ntlm python38Packages.IBMQuantumExperience python38Packages.ntlm-auth python38Packages.requests_ntlm

Detailed logs for python3.8-pywinrm-0.4.1 say No module named 'kerberos', so probably unrelated:

winrm.vendor.requests_kerberos (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: requests_kerberos (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: requests_kerberos
Traceback (most recent call last):
  File "/build/pywinrm-0.4.1/winrm/vendor/requests_kerberos/kerberos_.py", line 18, in <module>
    import kerberos
ModuleNotFoundError: No module named 'kerberos'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/nix/store/11w4z4w7lszgflgb8j62bwqr15j5zm5a-python3-3.8.1/lib/python3.8/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/build/pywinrm-0.4.1/winrm/vendor/requests_kerberos/__init__.py", line 33, in <module>
    from .kerberos_ import HTTPKerberosAuth, REQUIRED, OPTIONAL, DISABLED
  File "/build/pywinrm-0.4.1/winrm/vendor/requests_kerberos/kerberos_.py", line 20, in <module>
    import winkerberos as kerberos
ModuleNotFoundError: No module named 'winkerberos'


======================================================================
ERROR: winrm.vendor.requests_kerberos (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: winrm.vendor.requests_kerberos
Traceback (most recent call last):
  File "/build/pywinrm-0.4.1/winrm/vendor/requests_kerberos/kerberos_.py", line 18, in <module>
    import kerberos
ModuleNotFoundError: No module named 'kerberos'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/nix/store/11w4z4w7lszgflgb8j62bwqr15j5zm5a-python3-3.8.1/lib/python3.8/unittest/loader.py", line 470, in _find_test_path
    package = self._get_module_from_name(name)
  File "/nix/store/11w4z4w7lszgflgb8j62bwqr15j5zm5a-python3-3.8.1/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/build/pywinrm-0.4.1/winrm/vendor/requests_kerberos/__init__.py", line 33, in <module>
    from .kerberos_ import HTTPKerberosAuth, REQUIRED, OPTIONAL, DISABLED
  File "/build/pywinrm-0.4.1/winrm/vendor/requests_kerberos/kerberos_.py", line 20, in <module>
    import winkerberos as kerberos
ModuleNotFoundError: No module named 'winkerberos'


----------------------------------------------------------------------
Ran 25 tests in 0.014s

FAILED (errors=2)
Test failed: <unittest.runner.TextTestResult run=25 errors=2 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=25 errors=2 failures=0>
builder for '/nix/store/zkagvwpddw362z15yi7fak541qyxa4j2-python3.8-pywinrm-0.4.1.drv' failed with exit code 1

Same for the 3.7 version.

pywinrm did build though on #83560 (comment).

In general that winkerberos part looks like 36a1d10 from #80828.

@nh2 nh2 mentioned this pull request Mar 28, 2020
Merged
10 tasks
@bhipple
pythonPackages.ntlm-auth: 1.0.3 -> 1.4.0 to fix build
99a2ed5 
On master and 20.03, this is failing to build on `python 3.8`.

https://hydra.nixos.org/build/115517329
https://hydra.nixos.org/build/114714922

CC @NixOS/nixos-release-managers
ZHF: NixOS#80379

Co-Authored-By: Niklas Hambüchen <mail@nh2.me>
(cherry picked from commit 97f09ff)
@bhipple bhipple reopened this Mar 29, 2020
@bhipple
Copy link
Contributor Author

bhipple commented Mar 29, 2020

Indeed it was useful; I backported the winkerberos fix in #83631, and now this builds:

12 package updated:
python2.7-IBMQuantumExperience python2.7-ntlm-auth (1.0.3 → 1.4.0) python2.7-pywinrm python2.7-requests_ntlm python2.7-resampy python3.7-IBMQuantumExperience python3.7-ntlm-auth (1.0.3 → 1.4.0) python3.7-pywinrm python3.7-requests_ntlm python3.8-IBMQuantumExperience python3.8-ntlm-auth (1.0.3 → 1.4.0) python3.8-requests_ntlm

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/bhipple/.cache/nixpkgs-review/pr-83564/build.nix
https://github.com/NixOS/nixpkgs/pull/83564
1 package marked as broken and skipped:
python27Packages.resampy

11 package built:
python27Packages.IBMQuantumExperience python27Packages.ntlm-auth python27Packages.pywinrm python27Packages.requests_ntlm python37Packages.IBMQuantumExperience python37Packages.ntlm-auth python37Packages.pywinrm python37Packages.requests_ntlm python38Packages.IBMQuantumExperience python38Packages.ntlm-auth python38Packages.requests_ntlm

@worldofpeace worldofpeace merged commit 4ebb91a into NixOS:release-20.03 Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@elasticdog elasticdog Awaiting requested review from elasticdog

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @nh2 @worldofpeace