Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] chromium: Enable swiftshader by default #83562

Merged
merged 1 commit into from Mar 28, 2020
Merged

[20.03] chromium: Enable swiftshader by default #83562

merged 1 commit into from Mar 28, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Mar 28, 2020 •
edited

Motivation for this change

Backport of enabling swiftshader by default (#83304), so that headless OpenGL works out of the box in Chromium for 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2
chromium: Enable swiftshader by default.
d59be29 
This makes it possible to use chromium headless with WebGL
(e.g. for webdriver tests) without having to rebuild from source.

The upstram default is to enable, thus simply removing our disabling switch.

Also fixes NixOS#41918.

(cherry picked from commit 015bb28)
@nh2 nh2 requested a review from primeos March 28, 2020 01:57
@nh2 nh2 mentioned this pull request Mar 28, 2020
Merged
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented Mar 28, 2020

Still building, result will be available tomorrow.

@nh2
Copy link
Contributor Author

nh2 commented Mar 28, 2020

Still building, result will be available tomorrow.

It's working, same as in #83304.

@primeos primeos merged commit 25d25cd into NixOS:release-20.03 Mar 28, 2020
@primeos
Copy link
Member

primeos commented Mar 28, 2020

Merged, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos Awaiting requested review from primeos

@thefloweringash thefloweringash Awaiting requested review from thefloweringash

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @primeos