Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] rt: fix build error #83566

Merged
merged 1 commit into from Mar 28, 2020
Merged

[20.03] rt: fix build error #83566

merged 1 commit into from Mar 28, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 28, 2020 •
edited

Backport of #80677

Motivation for this change

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp @mmilata
rt: fix build error
fd6c92e 
ZHF: NixOS#80379
https://hydra.nixos.org/build/113061284

Added requiredPerlModules as suggested for similar problem as described for
similar problem here:
NixOS#72783 (comment)

(cherry picked from commit 3e50e26)
@mmilata mmilata mentioned this pull request Mar 28, 2020
Merged
10 tasks
@worldofpeace
Copy link
Contributor

This still seems to fail at tests.

@mmilata
Copy link
Member Author

mmilata commented Mar 28, 2020

Yes, sucessful build requires #83565 too.

@bhipple
Copy link
Contributor

bhipple commented Mar 28, 2020 •
edited

https://hydra.nixos.org/build/115505981/nixlog/2

Merged the other PR, this one now appears to pass all buid/tests with nixpkgs-review:

[8 built, 213 copied (69.1 MiB), 19.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83566
1 package built:
rt

@bhipple bhipple merged commit b88ff46 into NixOS:release-20.03 Mar 28, 2020
@mmilata mmilata deleted the rt-build-fix-20.03 branch March 28, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmilata @worldofpeace @bhipple @stigtsp