Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcs3: 0.0.6-8187-790962425 -> 0.0.8-9300-341fdf7eb #82998

Merged
merged 1 commit into from Mar 28, 2020
Merged

rpcs3: 0.0.6-8187-790962425 -> 0.0.8-9300-341fdf7eb #82998

merged 1 commit into from Mar 28, 2020

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Mar 20, 2020 •
edited by bhipple

Motivation for this change

Resolves #82954

See: #65399

Took the chance to update the version as well as the Qt build stuff.

While there is a tagged 0.0.9 release, it requires a Qt version >= 5.14 and the latest version we seem to package is 5.12.

cc @dali99. Build was tested and emulator starts up, not intensely tested because I don't have the required images to run anything with it. Maybe you could give that a shot?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    575256384 -> 402994504
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar March 20, 2020 14:21
@bhipple
Copy link
Contributor

bhipple commented Mar 28, 2020

@GrahamcOfBorg build rpcs3

When I try to build it, git clone seems to hang indefinitely. Let's see if the bot can still build it.

@bhipple
Copy link
Contributor

bhipple commented Mar 28, 2020

Nevermind, was an issue with my VPN. Local build now works and binary shows usage, unlike master version which crashes with qt issues.

@bhipple bhipple merged commit b96cdee into NixOS:master Mar 28, 2020
@bhipple bhipple mentioned this pull request Mar 28, 2020
Merged
10 tasks
@OPNA2608 OPNA2608 deleted the update-rpcs3 branch April 27, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPCS3 Needs QTWrapping
2 participants
@OPNA2608 @bhipple