Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex-mpv-shim: v1.7.12 -> v1.7.14 #83561

Merged
merged 1 commit into from Mar 28, 2020
Merged

plex-mpv-shim: v1.7.12 -> v1.7.14 #83561

merged 1 commit into from Mar 28, 2020

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Mar 28, 2020 •
edited

Motivation for this change

This updates plex-mpv-shim to the latest stable build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author 

> nix-review pr 83561
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/83561/head:refs/nixpkgs-review/1
From https://github.com/NixOS/nixpkgs
 + e89a95b2d41...da155fe7511 refs/pull/83561/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/cole/.cache/nixpkgs-review/pr-83561-1/nixpkgs 774ddebd87174173db00a9e8160325be4fc5d3e8
Preparing worktree (detached HEAD 774ddebd871)
Updating files: 100% (21292/21292), done.
HEAD is now at 774ddebd871 Merge pull request #83472 from Mic92/propragate-darwin-go
$ nix-env -f /home/cole/.cache/nixpkgs-review/pr-83561-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit da155fe7511c82dc2167e596f92ac65e018b3b12
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/pr-83561-1/nixpkgs -qaP --xml --out-path --show-trace --meta
1 package updated:
plex-mpv-shim (1.7.12 → 1.7.14)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/pr-83561-1/build.nix
[3 built, 18 copied (12.9 MiB), 3.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83561
1 package built:
plex-mpv-shim

$ nix-shell /home/cole/.cache/nixpkgs-review/pr-83561-1/shell.nix

@ofborg ofborg bot removed the 6.topic: python label Mar 28, 2020
jonringer
jonringer approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/83561
1 package built:
plex-mpv-shim

@jonringer jonringer merged commit 596b601 into NixOS:master Mar 28, 2020
@colemickens colemickens deleted the nixpkgs-plex-mpv-shim branch December 30, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @jonringer