Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.matplotlib: remove propagated nose dep #83505

Merged
merged 5 commits into from Mar 27, 2020
Merged

python3Packages.matplotlib: remove propagated nose dep #83505

merged 5 commits into from Mar 27, 2020

Conversation

bcdarwin
Copy link
Member

Motivation for this change

Matplotlib doesn't even use nose anymore, so there is no reason for nose to be in the matplotlib closure, much less propagatedBuildInputs.

Restored matplotlib to checkInputs for some packages which failed to build as a result. It's possible that other currently non-building packages also require this modification.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin changed the title pythonPackages.matplotlib: remove propagated nose dep python3Packages.matplotlib: remove propagated nose dep Mar 27, 2020
FRidh
FRidh approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, nose has been there since nixpkgs was still in svn. Nobody noticed.

jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

built the first 80 packages, failures are broke on master. Fairly certain this won't cause any regressions

[6/80/186 built (11 failed), 316 copied (2841.5/2842.8 MiB), 1235.2 MiB DL] building cq-editor-0.1RC1 (bui ...

@jonringer jonringer merged commit 6f9f91d into NixOS:master Mar 27, 2020
@bcdarwin bcdarwin deleted the matplotlib-no-propagate-nose branch March 27, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@jonringer jonringer jonringer approved these changes

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

@jluttine jluttine Awaiting requested review from jluttine

@globin globin Awaiting requested review from globin

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @FRidh @jonringer