Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! --> ###### Motivation for this change #83556

Closed
wants to merge 837 commits into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 28, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CohenCyril and others added 30 commits March 11, 2020 17:19
The previously committed checksums seem to have been mistakenly taken
directly from fetchurl without fetchpatch normalization.

(cherry picked from commit adfb8a0)
[20.03] nixos/initrd-network: always run postCommands
9458ec4 removed the ftp pam service which was used by default by vsftpd

(cherry picked from commit 7ab00c4)
(cherry picked from commit f908cf4)
(cherry picked from commit feb9b1b)
This test fails due to OOM on the VM. Setting the memory of the VM to
1024 lets the test succeed.

Cc: @flokli
(cherry picked from commit 534f133)
or vgo2nix might not be able to resolve some dependencies.

(cherry picked from commit d2061f0)
(cherry picked from commit fd04c3a)
It contains some "high impact" security fixes; announcement:
https://www.mozilla.org/en-US/firefox/68.6.0/releasenotes/

Brief testing on 20.03 shows no issues for me.
(cherry picked from commit 8899c72)
Brief testing showed no issues.
(cherry picked from commit 281bd03)
(cherry picked from commit f88cd71)
@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020

Oops, wrong arguments passed between hub and emacs on that one :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet