Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetch-request-css-cross-origin.https.html #22486

Merged
merged 1 commit into from Mar 27, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 27, 2020

The upstream change [1] updated assert_throws_dom() but it seems
the test wasn't updated together. Update the test to pass a
constructor to follow changes which are done by the upstream change.

[1] 4ba5bc3

Bug: 1054772
Change-Id: Icb6edae96758445a861634e330072c364084ee4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123571
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753924}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

The upstream change [1] updated assert_throws_dom() but it seems
the test wasn't updated together. Update the test to pass a
constructor to follow changes which are done by the upstream change.

[1] 4ba5bc3

Bug: 1054772
Change-Id: Icb6edae96758445a861634e330072c364084ee4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123571
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753924}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants