Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.faulthandler: 3.1 -> 3.2 and fix build; python2Packages.pytest-faulthandler: remove #83466

Merged
merged 3 commits into from Mar 27, 2020
Merged

python2Packages.faulthandler: 3.1 -> 3.2 and fix build; python2Packages.pytest-faulthandler: remove #83466

merged 3 commits into from Mar 27, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 27, 2020 •
edited

It is currently failing on master and 20.03. I spent some time reading the src
code but was not able to figure out why the env var activation is not working.
Since this is currently failing, and since it's dying alongside python 2 anyways
I propose we just disable the 1 failing test.

There's some more information inline in the comment if someone wants to fix this
or dig further.

ZHF: #80379

CC @FRidh @singron I tried the obvious stuff, like unsetting the windows argument or the pip flags, but it didn't seem to make a difference. Perhaps this makes more sense to you?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
python2Packages.faulthandler: 3.1 -> 3.2 and fix build
215e55b 
It is currently failing on master and 20.03. I spent some time reading the src
code but was not able to figure out why the env var activation is not working.
Since this is currently failing, and since it's dying alongside python 2 anyways
I propose we just disable the 1 failing test.

There's some more information inline in the comment if someone wants to fix this
or dig further.
@bhipple
python2Packages.pytest-faulthandler: remove package
2b531f9 
This has been upstreamed into pytest itself as of pytest 5.0, which we have:
https://github.com/pytest-dev/pytest-faulthandler

Since it should no longer be used, let's remove from nix.
@bhipple bhipple changed the title python27Packages.faulthandler: 3.1 -> 3.2 and fix build python2Packages.faulthandler: 3.1 -> 3.2 and fix build; python2Packages.pytest-faulthandler: remove Mar 27, 2020
@bhipple
Copy link
Contributor Author

bhipple commented Mar 27, 2020

Also removing pytest-faulthandler, since per upstream it should no longer be used w/ pytest >= 5.0:
https://github.com/pytest-dev/pytest-faulthandler

@ofborg ofborg bot requested a review from sauyon March 27, 2020 04:36
@bhipple
Copy link
Contributor Author

bhipple commented Mar 27, 2020 

$ nix-env -f /home/bhipple/.cache/nixpkgs-review/rev-3f921f3a459c6548c70278c6d53ada0e92466dfa/nixpkgs -qaP --xml --out-path --show-trace --meta
44 package updated:
bcc bpftrace can-isotp chipsec digimend-unstable digitalbitbox evdi-unstable evdi-unstable gdata-sharp glibc libselinux mba6x_bl nix-linter-unstable nixpart nixpart php-couchbase php-couchbase php-pcs php-pcs php-php_excel php-php_excel php-php_excel php-php_excel php-php_excel php-php_excel php-v8 php-v8 php-v8 php-v8 php-v8 php-v8 php-v8js php-v8js prl-tools pyblock pyblock python-notify python-notify python2.7-faulthandler (3.1 → 3.2) python2.7-habanero python2.7-handout python2.7-hass-nabucasa qes r8125

3 package removed:
python2.7-pytest-faulthandler (†9.003.02) python3.7-pytest-faulthandler (†9.003.02) python3.8-pytest-faulthandler (†9.003.02)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/bhipple/.cache/nixpkgs-review/rev-3f921f3a459c6548c70278c6d53ada0e92466dfa/build.nix
[1 built, 0.0 MiB DL]
43 package marked as broken and skipped:
digitalbitbox gdata-sharp glibcCross linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.prl-tools linuxPackages_hardkernel_4_14.r8125 nix-linter php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.couchbase php74Packages.pcs php74Packages.php_excel php74Packages.v8 python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python37Packages.nixpart python37Packages.notify python37Packages.pyblock python38Packages.libselinux python38Packages.nixpart python38Packages.notify python38Packages.pyblock qes

1 package built:
python27Packages.faulthandler

OK now I think we have something reasonable to review :)

jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83466
1 package marked as broken and skipped:
pants

1 package built:
python27Packages.faulthandler

pkgs/development/python-modules/faulthandler/disable-env-test.patch Show resolved Hide resolved
@jonringer jonringer merged commit acfe7e0 into NixOS:master Mar 27, 2020
@bhipple bhipple mentioned this pull request Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@sauyon sauyon Awaiting requested review from sauyon

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @jonringer