Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "luaPackages.luv: 1.30.0-0 -> 1.34.1-1" #83532

Merged
merged 1 commit into from Mar 29, 2020
Merged

Revert "luaPackages.luv: 1.30.0-0 -> 1.34.1-1" #83532

merged 1 commit into from Mar 29, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Mar 27, 2020 •
edited

This reverts commit eaa4728.

With 81461cf luv also needs to be
downgraded until luarocks can be updated to 3.3.1 again.

Fixes #82727

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
Revert "luaPackages.luv: 1.30.0-0 -> 1.34.1-1"
2206369 
This reverts commit eaa4728.

With 81461cf luv also needs to be
downgraded until luarocks can be updated to 3.3.1 again.

Fixes NixOS#82727
@teto
Copy link
Member

teto commented Mar 28, 2020

On the luv issue, as we have no proper fix really (the current fix is just as complicated as the current one), I am fine with this. I have not understood yet if the issue on darwin was random or systematic (i.e., if it could be fixed by trying several times).

@LnL7
Copy link
Member Author

LnL7 commented Mar 28, 2020

For reference the darwin build worked fine with luarocks-3.3.1 + luv-1.34.1-1 (even without your changes). So once #80528 is resolved we just have to make sure to update both.

@LnL7 LnL7 merged commit f4da410 into NixOS:master Mar 29, 2020
@LnL7 LnL7 deleted the darwin-neovim branch March 29, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neovim failing to build on Darwin and Darwin Hydra?
2 participants
@LnL7 @teto