Raw Clipboard: Implement read. #22507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 27, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2107156
branch
6 times, most recently
from
898004b
to
b442acc
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2107156
branch
8 times, most recently
from
25ef561
to
5ea952c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2107156
branch
3 times, most recently
from
fccc50f
to
99855d4
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2107156
branch
4 times, most recently
from
53a2bfb
to
93d7bf2
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2107156
branch
from
93d7bf2
to
0f69b1a
Compare
Implement Raw Clipboard interface for reading arbitrary data. Also, implements mock interfaces for automated content_shell/WPT tests. The browser-side change is more simple than the equivalent Raw Write and Raw Format CLs due to platform-specific code already being handled in ui::Clipboard::read(). The Raw Clipboard API is only accessible if the user turns on the Raw Clipboard feature flag, and explicitly provides permission via permission prompt. These checks are contained in both the browser and renderer. Design Doc: https://tinyurl.com/raw-clipboard-access-design Bug: 897289 Change-Id: Ic5a778cf4c6421ea15bf44faebf08d23e3b39b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107156 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766694}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2107156
branch
from
0f69b1a
to
5f938fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Raw Clipboard interface for reading arbitrary data. Also,
implements mock interfaces for automated content_shell/WPT tests.
The browser-side change is more simple than the equivalent Raw Write and
Raw Format CLs due to platform-specific code already being handled in
ui::Clipboard::read().
The Raw Clipboard API is only accessible if the user turns on the
Raw Clipboard feature flag, and explicitly provides permission via
permission prompt. These checks are contained in both the browser and
renderer.
Design Doc: https://tinyurl.com/raw-clipboard-access-design
Bug: 897289
Change-Id: Ic5a778cf4c6421ea15bf44faebf08d23e3b39b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107156
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766694}