Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin-mpv-shim: 1.4.1 -> 1.4.2 #83490

Merged
merged 2 commits into from Mar 27, 2020
Merged

jellyfin-mpv-shim: 1.4.1 -> 1.4.2 #83490

merged 2 commits into from Mar 27, 2020

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Mar 27, 2020 •
edited

Motivation for this change

https://github.com/iwalton3/jellyfin-mpv-shim/releases/tag/v1.4.2

Things done

also updated python-mpv-jsonipc>=1.1.8

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jojosch jojosch changed the title Jellyfin mpv shim 1.4.2 jellyfin-mpv-shim: 1.4.1 -> 1.4.2 Mar 27, 2020
@ofborg ofborg bot requested a review from colemickens March 27, 2020 12:46
spacekookie
spacekookie approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@spacekookie spacekookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it builds and runs for me. It can't actually connect to my server but I suspect that's unrelated 😉

jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
gui launches fine

[7 built, 14 copied (28.6 MiB), 6.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83490
4 package built:
jellyfin-mpv-shim plex-mpv-shim python37Packages.python-mpv-jsonipc python38Packages.python-mpv-jsonipc

@jonringer jonringer merged commit ab55af2 into NixOS:master Mar 27, 2020
@jojosch jojosch deleted the jellyfin-mpv-shim_1.4.2 branch March 27, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacekookie spacekookie spacekookie approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@colemickens colemickens Awaiting requested review from colemickens

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jojosch @spacekookie @jonringer