Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solargraph: 0.38.0 -> 0.38.6 #83520

Merged
merged 1 commit into from Mar 27, 2020
Merged

solargraph: 0.38.0 -> 0.38.6 #83520

merged 1 commit into from Mar 27, 2020

Conversation

douglas
Copy link
Contributor

@douglas douglas commented Mar 27, 2020 •
edited

Motivation for this change

We're using solargraph with nix in a huge codebase and seems we're being affected by this bug: castwide/solargraph#278 (comment)

It should be good after the update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm @alyssais @filalex77

jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/83520
1 package built:
solargraph

@jonringer jonringer merged commit dc4a0da into NixOS:master Mar 27, 2020
@jonringer
Copy link
Contributor

@douglas congrats on your first PR :)

@douglas
Copy link
Contributor Author

douglas commented Mar 27, 2020 •
edited

Yay! I'm so happy for being able to contribute! Hope to help more from now on 🎉

Thanks for the quick reviews, friends 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@douglas @jonringer @Br1ght0ne @Janik-Haag