Skip to content

NURBS issue with torus #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phkahler opened this issue Sep 9, 2019 · 1 comment
Closed

NURBS issue with torus #471

phkahler opened this issue Sep 9, 2019 · 1 comment
Labels
bug mesh NURBS

Comments

@phkahler
Copy link
Member

phkahler commented Sep 9, 2019

By using lathe around a point that is not in the sketch plane, we can create a torus with an oval cross section. By dragging that point we can change the aspect ration of that section, but as shown here this can result in NURBS errors. Even worse, this will also happen if we force to triangle mesh.

torus_issue
@whitequark whitequark added the bug label Sep 9, 2019
@phkahler phkahler mentioned this issue Sep 9, 2019
Closed
phkahler added a commit to phkahler/solvespace that referenced this issue Sep 9, 2019
@phkahler
Limit u,v range between 0 and 1 in Newton. Fixes issue solvespace#471
2ace69f
@phkahler phkahler mentioned this issue Sep 9, 2019
Merged
phkahler added a commit that referenced this issue Mar 27, 2020
@phkahler
Nurbs (#473)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f7b6f69 
* Limit u,v range between 0 and 1 in Newton. Fixes issue #471
* Change the math for projecting a point onto a plane to work better with non-orthogonal U,V derivatives in several places. Fixes #472.
@phkahler
Copy link
Member Author

Fixed with #473

Sorry, something went wrong.

@ruevs ruevs mentioned this issue Oct 15, 2020
Open
devin-ai-integration bot pushed a commit to erkinalp/solvespace that referenced this issue Apr 3, 2025
@phkahler
Nurbs (solvespace#473)
8e5145e 
* Limit u,v range between 0 and 1 in Newton. Fixes issue solvespace#471
* Change the math for projecting a point onto a plane to work better with non-orthogonal U,V derivatives in several places. Fixes solvespace#472.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mesh NURBS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @phkahler