[css-flexbox] Move flexitem-no-margin-collapsing.html test to WPT #22488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 27, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2123573
branch
2 times, most recently
from
bf9a347
to
6311383
Compare
This CL moves flex-item-contains-strict.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, a proper title, and test description. Bug: 1063749 Change-Id: I8c688b51efc8890250073778b76bef1f23f8fa24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123573 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#754783}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2123573
branch
from
6311383
to
389c920
Compare
|
Seemingly random git failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL moves flex-item-contains-strict.html test from
css3/css-flexbox to external/wpt/css/css-flexbox with WPT
styles, adding links to the relevant specs, a proper title,
and test description.
Bug: 1063749
Change-Id: I8c688b51efc8890250073778b76bef1f23f8fa24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123573
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#754783}