[20.03] python2Packages.faulthandler: 3.1 -> 3.2 and fix build #83508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently failing on master and 20.03. I spent some time reading the src code but was not able to figure out why the env var activation is not working. Since this is currently failing, and since it's dying alongside python 2 anyways I propose we just disable the 1 failing test. There's some more information inline in the comment if someone wants to fix this or dig further. (cherry picked from commit 643d102)
This has been upstreamed into pytest itself as of pytest 5.0, which we have: https://github.com/pytest-dev/pytest-faulthandler Since it should no longer be used, let's remove from nix. (cherry picked from commit f5ffd14)
…lthandler (cherry picked from commit acfe7e0)
bhipple
changed the title
drewrisinger
approved these changes
Mar 27, 2020
jonringer
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the commits in #83466, which
"fixes" the broken
faulthandlerbuild on python2 by disabling the 1 failingtest, and removing bad dependencies on
pytest-faulthandler(which should nolonger be used as of pytest 5.0).
There are ~40 python packages that depend on it and can now attempt builds!
CC @NixOS/nixos-release-managers
ZHF: #80379