Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-dl: init at (unstable-)2019-09-22 #83521

Merged
merged 1 commit into from Mar 28, 2020
Merged

matrix-dl: init at (unstable-)2019-09-22 #83521

merged 1 commit into from Mar 28, 2020

Conversation

herrwiese
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@herrwiese
Copy link
Contributor Author

@GrahamcOfBorg build matrix-dl

symphorien
symphorien approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works.

As a maintainer, that would be nice if you could open an issue upstream to clarify the license.

Ma27
Ma27 approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

As @symphorien already mentioned, it would be great to file an upstream bug due to the licensing issue though :)

@Ma27 Ma27 merged commit 74deced into NixOS:master Mar 28, 2020
@Ma27
Copy link
Member

Ma27 commented Mar 28, 2020

@herrwiese thanks!

@herrwiese
Copy link
Contributor Author

Thanks @Ma27 and @symphorien. I actually found it in setup.py 🤦‍♂️ See #83686

@herrwiese herrwiese deleted the for-master/matrix-dl branch April 1, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@symphorien symphorien symphorien approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@herrwiese @Ma27 @symphorien