Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osinfo-db-tools: 1.6.0 -> 1.7.0, osinfo-db: 20200214 -> 20200515, libosinfo: fix test #83534

Merged
merged 3 commits into from May 25, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 27, 2020

Upstream switched archive format tar.gz -> tar.xz, that's probably why the bot didn't pick this up.

If you are reading this, it's possible you know something about libosinfo. In that case, please take a look at this PR that attempts to add NixOS to osinfo-db: https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/107

cc @bjornfor @jtojnar @jonringer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have libosinfo bump on staging.

@worldofpeace
Copy link
Contributor

@jtojnar You mean just libosinfo and not osinfo-db etc? (reading that I would think to just close the PR)

@jtojnar
Copy link
Contributor

jtojnar commented Mar 28, 2020

Yeah, osinfo-db & osinfo-db-tools still need a bump.

@mmilata mmilata changed the base branch from master to staging March 28, 2020 01:22
@mmilata mmilata changed the title libosinfo: 1.6.0 -> 1.7.1, osinfo-db-tools: 1.6.0 -> 1.7.0, osinfo-db: 20200214 -> 20200325 osinfo-db-tools: 1.6.0 -> 1.7.0, osinfo-db: 20200214 -> 20200325, libosinfo: fix test Mar 28, 2020
@mmilata
Copy link
Member Author

mmilata commented Mar 28, 2020

Ah, I didn't notice it's in staging. Updated the PR, PTAL. Apologies to everyone I accidentally tagged for review.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde labels Mar 28, 2020
};

nativeBuildInputs = [ pkgconfig gettext perl ];
nativeBuildInputs = [ meson ninja pkgconfig gettext perl python3 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python3 is only used at compile time, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmilata mmilata changed the base branch from staging to master April 9, 2020 00:14
@mmilata mmilata changed the title osinfo-db-tools: 1.6.0 -> 1.7.0, osinfo-db: 20200214 -> 20200325, libosinfo: fix test osinfo-db-tools: 1.6.0 -> 1.7.0, osinfo-db: 20200214 -> 20200515, libosinfo: fix test May 23, 2020
@mmilata
Copy link
Member Author

mmilata commented May 23, 2020

Updated osinfo-db to 20200515, first release containing records for NixOS.


Result of nixpkgs-review pr 83534 1

24 packages built:
- deja-dup
- dropbox-cli
- empathy
- gnome-photos
- gnome3.cheese
- gnome3.file-roller
- gnome3.gnome-books
- gnome3.gnome-boxes
- gnome3.gnome-contacts
- gnome3.gnome-control-center
- gnome3.gnome-documents
- gnome3.gnome-terminal
- gnome3.gnome-tweak-tool
- gnome3.gnome-user-share
- gnome3.nautilus
- gnome3.nautilus-python
- gnome3.totem
- gnome3.tracker-miners
- gnomeExtensions.gsconnect
- libosinfo
- osinfo-db
- osinfo-db-tools
- pantheon.extra-elementary-contracts
- virtmanager (virt-manager)

@jtojnar jtojnar merged commit 4d9de2d into NixOS:master May 25, 2020
@jtojnar
Copy link
Contributor

jtojnar commented May 25, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants