Fix rounding in DelayNode buffer size calculation #22506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DelayNode needs to buffer maxDelayTime worth of sample frames,
plus one for interpolation. If maxDelayTime isn't an integer
number of frames, we have to round it up -- otherwise the buffer
ends up one frame too short, causing the interpolation to wrap
around and access the newest input instead of the oldest.
Bug: 1065110
Change-Id: Ia47dbd07c3b3b48734c03442a020d76a680eaaa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122852
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754595}