Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding in DelayNode buffer size calculation #22506

Merged
merged 1 commit into from Mar 30, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 27, 2020

DelayNode needs to buffer maxDelayTime worth of sample frames,
plus one for interpolation. If maxDelayTime isn't an integer
number of frames, we have to round it up -- otherwise the buffer
ends up one frame too short, causing the interpolation to wrap
around and access the newest input instead of the oldest.

Bug: 1065110
Change-Id: Ia47dbd07c3b3b48734c03442a020d76a680eaaa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122852
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754595}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2122852 branch 2 times, most recently from 901bdc8 to 566633c Compare March 27, 2020 23:11
DelayNode needs to buffer maxDelayTime worth of sample frames,
plus one for interpolation.  If maxDelayTime isn't an integer
number of frames, we have to round it up -- otherwise the buffer
ends up one frame too short, causing the interpolation to wrap
around and access the newest input instead of the oldest.

Bug: 1065110
Change-Id: Ia47dbd07c3b3b48734c03442a020d76a680eaaa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122852
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754595}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants