Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cinnamon.mint-y-icons: init at unstable-2020-03-21 #83126

Merged
merged 1 commit into from Mar 27, 2020
Merged

cinnamon.mint-y-icons: init at unstable-2020-03-21 #83126

merged 1 commit into from Mar 27, 2020

Conversation

mkg20001
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this theme inherits hicolor-icon-theme and adwaita-icon-theme https://github.com/linuxmint/mint-y-icons/blob/4a958a678b0e3298b3190c3a46881c5cc73c12a8/usr/share/icons/Mint-Y-Red/index.theme#L3

so you need to propagate them.

You should also generate an icon cache like

postFixup =  ''
  gtk-update-icon-cache $out/share/icons/$directory
'';

which adds a native dependency on gtk3.

Lastly set dontDropIconThemeCache = true; so the setup-hook in gtk3 doesn't remove it.

@mkg20001 mkg20001 force-pushed the pkg/mint-y-icons branch 2 times, most recently from a64dea7 to d2ddba6 Compare March 24, 2020 07:10
worldofpeace
worldofpeace approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the date in your commit have to dashes.

@mkg20001 mkg20001 changed the title cinnamon.mint-y-icons: init at unstable-20200321 cinnamon.mint-y-icons: init at unstable-2020-03-21 Mar 25, 2020
@worldofpeace worldofpeace merged commit 5e65872 into NixOS:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkg20001 @worldofpeace