Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firejail: local profile handling fixed #83515

Merged
merged 1 commit into from Mar 28, 2020
Merged

firejail: local profile handling fixed #83515

merged 1 commit into from Mar 28, 2020

Conversation

snicket2100
Copy link
Contributor

made it possible to place local profiles in ~/.config/firejail, as well as in /etc/firejail.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@snicket2100
firejail: local profile handling fixed
a63f6a7 
made it possible to place local profiles in `~/.config/firejail`,
as well as in `/etc/firejail`.
@snicket2100 snicket2100 mentioned this pull request Mar 27, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from 7c6f434c March 27, 2020 17:54
@7c6f434c
Copy link
Member

@thatsmydoing does that work?

@thatsmydoing
Copy link
Contributor

I can confirm that it works for me with putting files in ~/.config/firejail 👍

@snicket2100
Copy link
Contributor Author

So it does with /etc/firejail.

I am not claiming I am perfectly happy with this solution, but I couldn't come up with anything more elegant that would cover both cases, without patching firejail itself.

@7c6f434c 7c6f434c merged commit 7dc2439 into NixOS:master Mar 28, 2020
@snicket2100 snicket2100 deleted the firejail-fix branch March 28, 2020 11:47
@ryneeverett ryneeverett mentioned this pull request Sep 1, 2020
Closed
@ryneeverett ryneeverett mentioned this pull request Jan 25, 2021
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snicket2100 @7c6f434c @thatsmydoing