unbound: don't implicitly enable local resolver in resolvconf #83540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't implicitly enable local resolving (resulting in `nameserver 127.0.0.1`
in */etc/resolv.conf*) when enabling unbound. Unbound may have been configured
to not even listen on the loopback device, or the system may have otherwise
been configured in a way which make local resolving undesired.
The user can instead explicitly enable local resolving using one of the two
following methods:
networking.nameservers = [ "127.0.0.1" "::1" ];
networking.resolvconf.useLocalResolver = true;
The implicit functionality was introduced in 01b90dc.
stigok
force-pushed
the
unbound-no-implicit-local-resolver
branch
from
18b6021
to
e404951
Compare
|
AFAIK the DNS server packages that defaults to |
|
No traction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Don't implicitly enable local resolving (resulting in
nameserver 127.0.0.1in /etc/resolv.conf) when enabling unbound. Unbound may have been configured to not even listen on the loopback device, or the system may have otherwise been configured in a way which make local resolving undesired.The user can instead explicitly enable local resolving using one of the two following methods:
The implicit functionality was introduced in 01b90dc and was applied to other DNS resolvers as well.
For example: in a case where you are setting up a DNS server for a subnet you are part of, configuring
interfacesto not include127.0.0.1, there is nothing listening on127.0.0.1:53, butresolvconfis still setting it as the system wide resolver.It makes more sense to let the user set this option explicitly if it is your desired behavior. E.g. by setting
networking.nameserversto127.0.0.1which I would expect I'd have to do anyway.There may be other resolvers affected by this same implicit setting which came in with 01b90dc, however none of which I have experience with.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)