Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xaver.clang-format init at 1.9.0 #83541

Closed
wants to merge 1 commit into from
Closed

xaver.clang-format init at 1.9.0 #83541

wants to merge 1 commit into from

Conversation

zeratax
Copy link
Contributor

@zeratax zeratax commented Mar 27, 2020

Motivation for this change

More complete vscode-extensions

Things done

I'd like to add a few more extensions I use and wanted to know if I should continue adding these in individual PRs or if it was better to add all vscode-extensions I want to add in one PR

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zeratax zeratax requested a review from jonringer as a code owner March 27, 2020 23:09
jonringer
jonringer reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please change the existing commit to:

vscode-extensions.xaver.clang-format init at 1.9.0

otherwise LGTM

maintainers/maintainer-list.nix
Comment on lines +8288 to +8293
zeratax = {
email = "mail@zera.tax";
github = "ZerataX";
githubId = 5024958;
name = "Jona Abdinghoff";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this into a separate commit:

maintainers: add <name>
```

@zeratax zeratax closed this Aug 11, 2020
@zeratax zeratax mentioned this pull request Aug 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zeratax @jonringer @Janik-Haag