Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steamrt update #83486

Merged
merged 2 commits into from Mar 27, 2020
Merged

Steamrt update #83486

merged 2 commits into from Mar 27, 2020

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Mar 27, 2020 •
edited

Motivation for this change

Update the Steam runtime and add dependencies for Prison Architect

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

steam opens fine
prison architect opens fine

https://github.com/NixOS/nixpkgs/pull/83486
7 package built:
kodiPlugins.steam-launcher linux-steam-integration lutris steam steam-run steam-run-native steamcmd

@jonringer jonringer merged commit 3a15a13 into NixOS:master Mar 27, 2020
@nyanloutre nyanloutre deleted the steamrt_update branch March 28, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @jonringer