Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uberwriter: renamed to apostrophe #83503

Merged
merged 1 commit into from Apr 2, 2020
Merged

uberwriter: renamed to apostrophe #83503

merged 1 commit into from Apr 2, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

UberWriter was renamed to Apostrophe and the upstream repository moved to GNOME's Gitlab.

Is there by now a process for package renaming? I quickly checked, but it didn't find anything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@puzzlewolf
Copy link
Contributor

There is pkgs/top-level/aliases.nix. I couldn't quickly find documentation, but it seems to be used for this (e.g. 9a43587, fd86712).

@sternenseemann
Copy link
Member Author

Oh yeah that would work! I wonder though if it'd be worth to add an alias for this package, since it never entered a proper NixOS release as far as I can tell, only nixos-unstable.

@puzzlewolf
Copy link
Contributor

Hm, I don't know :) Maybe discuss on https://discourse.nixos.org/?

@sternenseemann
Copy link
Member Author

I think getting one or two opinions here would be enough. In aliases.nix it says

  ### Deprecated aliases - for backward compatibility

I don't think it makes sense to try to be backwards compatible to nixos-unstable necessarily.

@sternenseemann
uberwriter: renamed to apostrophe
db9a868 
* update 2020-01-24 -> 2020-03-29
* reflect change of name and main repository
@Mic92 Mic92 merged commit 46d919f into NixOS:master Apr 2, 2020
@sternenseemann sternenseemann deleted the apostrophe branch April 14, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @puzzlewolf @Mic92