Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.gruvbox-community: 2019-05-31 -> 2020-02-24 #83502

Merged
merged 1 commit into from Mar 28, 2020
Merged

vimPlugins.gruvbox-community: 2019-05-31 -> 2020-02-24 #83502

merged 1 commit into from Mar 28, 2020

Conversation

minijackson
Copy link
Member

Motivation for this change

A nice number of fixes since 2019-05-31 ^^

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Mar 27, 2020

The alias support I was talking about at your initial PR has since been implemented. Please make use of that instead, that way the plugin will be automatically updated in the future.

@minijackson minijackson force-pushed the vimPlugins-gruvbox-community-2020-02-24 branch from 5b4b136 to 1f18b2c Compare March 28, 2020 09:40
@minijackson minijackson force-pushed the vimPlugins-gruvbox-community-2020-02-24 branch from 1f18b2c to bf96f91 Compare March 28, 2020 09:45
timokau
timokau approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit d8cb79d into NixOS:master Mar 28, 2020
@minijackson minijackson deleted the vimPlugins-gruvbox-community-2020-02-24 branch July 20, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minijackson @timokau