Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ScrollTimeline] Do not show scrollbar to bypass flakiness on early Mac #22496

Merged
merged 1 commit into from Mar 30, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 27, 2020

The flaky tests are not related to worklet animations because it's the
reference file that is not painted correctly.

Mac scrollbars have their own painting path and they paint greedily.
There might be a race condition on the order of painting that caused the
scrollbar being completely black.

Bug: 946534
Change-Id: I5e2fab05e7a5ee5ec09dcab2a03606ca5ce1fd0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124296
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754480}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

The flaky tests are not related to worklet animations because it's the
reference file that is not painted correctly.

Mac scrollbars have their own painting path and they paint greedily.
There might be a race condition on the order of painting that caused the
scrollbar being completely black.

Bug: 946534
Change-Id: I5e2fab05e7a5ee5ec09dcab2a03606ca5ce1fd0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124296
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754480}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants