Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fcp-overflow test, it's erronous #22497

Merged
merged 1 commit into from Mar 27, 2020
Merged

Remove fcp-overflow test, it's erronous #22497

merged 1 commit into from Mar 27, 2020

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 27, 2020

An item inside overflow: hidden would have an empty bounding rect, and thus would never trigger FCP

@noamr noamr requested a review from npm1 March 27, 2020 14:59
npm1
npm1 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's wrong it's wrong! :) LGTM

@npm1 npm1 merged commit f94621b into master Mar 27, 2020
@npm1 npm1 deleted the remove-fcp-overflow branch March 27, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npm1 npm1 npm1 approved these changes

@spanicker spanicker Awaiting requested review from spanicker

Assignees

@spanicker spanicker

Labels
paint-timing wg-webperf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@noamr @npm1 @spanicker @wpt-pr-bot