New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: xrdesktop packages & gnome-shell xrdesktop #83527
base: master
Are you sure you want to change the base?
Conversation
Not sure what XR is (¿extended reality?) but we definitely should not patch GNOME Shell with random patches. |
@mkg20001 What you could do is make a variant of those packages with XR. Or maybe nixpkgs isn't the best place for those things, will the patches be sent upstream to gnome-shell ever? I think that is the only questionable thing, the xrdesktop packages are fine for nixpkgs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every fetchgit
from gitlab could be replaced with
fetchFromGitLab {
domain = "gitlab.freedesktop.org"
owner = "";
repo = "";
rev = "";
sha256 = ...;
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also want to include meta
information for all the new derivations.
As an aside I'm also skeptical about patching gnome-shell in this way, probably better to make an override, but as @jtojnar said not sure if nixpkgs is the right place for that. gnome-shell
and its reverse dependencies are fairly easy to compile locally, so the NUR
might be a better place.
I also have an overlay here for these packages: My understanding is that the authors are working to upstream their gnome changes. The version for KDE does not require any invasive patching, and could (in principle) be included in nixpkgs. However, I have not been able to get KDE to work yet with their latest version of xrdesktop. @mkg20001 I noticed your |
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
This would still be very nice to have. |
I marked this as stale due to inactivity. → More info |
Motivation for this change
Let's have some XR in nixOS
Todo:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)